Expose h2's server Connection::has_streams()#3875
Closed
arthurdandrea wants to merge 2 commits intohyperium:masterfrom
Closed
Expose h2's server Connection::has_streams()#3875arthurdandrea wants to merge 2 commits intohyperium:masterfrom
arthurdandrea wants to merge 2 commits intohyperium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose h2's server
Connection::has_streams()introduced in hyperium/h2#838, allowing external keepalive timeout management.Since hyper's Connection does not have a h2 Connection during handshake, I've exposed a
Connection::has_handshake_completed(), but I'm not sure if this is the best approach, maybe returningfalseonhas_streams()is good enough, or even returning Option from thehas_streams()method.